grep recurse argument supported on alpine #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 10, 2019 10:33
Following #3 option -r works both on alpine and macos
|
Hey! I just saw this, will finish reviewing next week. I noticed that the behavior might slightly change from using -R to using -r, in regards to following symlinks when found. My thinking was to just /shrug symlink following (never heard of symlinks usage inside test folders) and release this change on a major. But just in case, how would you actually follow symlinks in your grep version, out of curiosity? Ty for the PR! Have a nice week! |
Never had symlink in my tests, and I'm not a shell expert ;) Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #3
option -r works both on alpine and macos
I updated travis configuration also