-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more ak verbs #146
Add more ak verbs #146
Conversation
Codecov Report
@@ Coverage Diff @@
## main #146 +/- ##
==========================================
- Coverage 95.55% 95.44% -0.11%
==========================================
Files 19 19
Lines 1798 1889 +91
==========================================
+ Hits 1718 1803 +85
- Misses 80 86 +6
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking good to me. Something I noticed is a warning coming from the ak.full_like
test:
/Users/ddavis/.pyenv/versions/3.11.1/envs/dev/lib/python3.11/site-packages/awkward/operations/ak_full_like.py:160: DeprecationWarning: elementwise comparison failed; this will raise an error in the future.
if fill_value == 0 or fill_value is _ZEROS:
Getting triggered in upstream awkward, but for some reason I'm not able to reproduce it outside of the tests. Do you have a handle on what's going on here?
@borrow_docstring(ak.copy) | ||
def copy(array): | ||
raise DaskAwkwardNotImplemented("TODO") | ||
raise DaskAwkwardNotImplemented( | ||
"This function is not necessary in the context of dask-awkward." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this, a much better message!
@douglasdavis Yeah - I ran into the same weird irreproducibility problem, and I haven't had time to dig into to it really. Just implementing so far. I can take a look by the end of the week. For Otherwise the complete implementation requires the ability to repartition and shuffle dask-awkward arrays, which I think right now is step I'd like to add yet a few more verbs so we can chew on this. I'd like to check with @nsmith- to make sure we've got all the mostly common ones. I think with the PR we have so far we're pretty good but would like to get regular-use coverage mostly done. |
@agoose77 just FYI there are a number of TODO's in this PR that come from needing to |
@masonproffitt could you give this branch a try? |
@douglasdavis pending a bit of user testing this is good to go now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added one inline question, but other than that if you have nothing else to add I think this is good to go!
@lgray just want to confirm you have nothing else you'd like to add to this PR and I'll go ahead and merge! |
Nope, not for now! More will come later but I think this is enough from typical use patterns. |
I tested this, and the only new problem that came up was #151 |
Fixes #124
Fixes #128
add:
dak.argsort
foraxis != 0
#130)dak.broadcast_arrays
#128)remove:
structure.py