Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump datafusion-python to 34.0.0 #1290

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Bump datafusion-python to 34.0.0 #1290

wants to merge 1 commit into from

Conversation

charlesbluca
Copy link
Collaborator

No description provided.

andygrove
andygrove reviewed Apr 3, 2024
View reviewed changes
src/sql/optimizer.rs
Comment on lines -84 to -85
Arc::new(PushDownProjection::new()),
Arc::new(EliminateProjection::new()),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that these two rules were combined into a new OptimizeProjections rule, so perhaps we should be using that now?

andygrove
andygrove approved these changes Apr 3, 2024
View reviewed changes
Copy link
Contributor

@andygrove andygrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I left a comment about a missing optimizer rule. Nice to see the project move back to a using a versioned release of DataFusion.

@Michael-J-Ward
Copy link

Is there something that is keeping dask-sql using the pinned version of datafusion-python?

Asking because if there is, I'd like to fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andygrove andygrove andygrove approved these changes

@ayushdg ayushdg Awaiting requested review from ayushdg ayushdg will be requested when the pull request is marked ready for review ayushdg is a code owner

@galipremsagar galipremsagar Awaiting requested review from galipremsagar galipremsagar will be requested when the pull request is marked ready for review galipremsagar is a code owner

@jdye64 jdye64 Awaiting requested review from jdye64 jdye64 will be requested when the pull request is marked ready for review jdye64 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@charlesbluca @Michael-J-Ward @andygrove