Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install x86_64-apple-darwin target before building bindings on macos-latest #1329

Merged

Conversation

charlesbluca
Copy link
Collaborator

@charlesbluca charlesbluca commented Apr 26, 2024

Looks like we're starting to see failures in our macOS test builds:

https://github.com/dask-contrib/dask-sql/actions/runs/8852325552/job/24312113450?pr=1328

Taking the suggestion from the error logs seems to resolve things:

  = note: the `x86_64-apple-darwin` target may not be installed
  = help: consider downloading the target with `rustup target add x86_64-apple-darwin`

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.74%. Comparing base (b473fd6) to head (7db333d).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1329      +/-   ##
==========================================
- Coverage   85.32%   76.74%   -8.58%     
==========================================
  Files          77       77              
  Lines        4231     4231              
  Branches      791      791              
==========================================
- Hits         3610     3247     -363     
- Misses        453      838     +385     
+ Partials      168      146      -22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@charlesbluca charlesbluca changed the title Test macOS testing CI Install x86_64-apple-darwin target before building bindings on macos-latest Apr 26, 2024
@charlesbluca charlesbluca marked this pull request as ready for review April 26, 2024 20:19
@charlesbluca charlesbluca merged commit f1b4d93 into dask-contrib:main Apr 26, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants