Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add binder badge #60

Closed
wants to merge 1 commit into from
Closed

Conversation

raybellwaves
Copy link

@raybellwaves raybellwaves commented Oct 23, 2020

Closes #59

Had a very quick stab at this.

Couple things I need to look into:

  • Making sure the notebook pop-ups on entry
  • Ensuring the dashboard works

@codecov-io
Copy link

Codecov Report

Merging #60 into main will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              main       #60   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           31        31           
  Lines         1187      1187           
  Branches       156       156           
=========================================
  Hits          1187      1187           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 734da70...b923358. Read the comment docs.

@raybellwaves
Copy link
Author

The way to getting the dashboard to connect is probably somewhere in https://github.com/raybellwaves/xskillscore-tutorial

@mrocklin
Copy link

We might also consider adding an example to examples.dask.org .

There is pretty good infrastructure there to render notebooks as docs, provide badges, set up dashboards automatically, and so on. That site also gets decent traffic, which might help.

@raybellwaves raybellwaves marked this pull request as ready for review October 29, 2020 20:05
@raybellwaves
Copy link
Author

Note: I could update the notebook to use create_table following #63
I can also check that the example in the README is up to date as the notebook uses that example.

@nils-braun
Copy link
Collaborator

Hi @raybellwaves!
Thank you so much for working on this! That is a very good addon to the project. I really love that it is showing the dask dashboard right away.
I do not have a strong opinion here, but: do you think it makes sense to include the notebooks also into this repository or keep them separate? I think both has benefits and drawbacks, but in terms of maintainability, I guess keeping them in one spot with the code might be favorable. What do you think?

@raybellwaves
Copy link
Author

include the notebooks also into this repository

I think this is a good idea.

In addition, you are welcome to fork my repo and we can work in yours. May be easier for maintenance and you don't have to wait for me to merge any PR's

@nils-braun
Copy link
Collaborator

Ok! I have created another PR in #72, which adds the forked repo (and the notebooks).

I am fine with both working in your or the forked repo :-) But sure, it might make sense to keep things together!

@raybellwaves
Copy link
Author

Closed in favor of #72

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add binder badge
4 participants