Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify dask-sql API with blazing SQL #63

Merged
merged 17 commits into from
Nov 4, 2020
Merged

Conversation

nils-braun
Copy link
Collaborator

@nils-braun nils-braun commented Oct 28, 2020

Fixes #58

I have implemented (parts of) the blazingSQL API of the context - especially .sql, .create_table, .explain and .drop_table.

What is still missing:

  • let create_table also work on a hive cursor
  • think about implementing all the file system functions (e.g. .s3). However - in dask they are not really needed as all the parameters can just be passed via the call to create_table. -> I decided against implementing them for now. Everything can be achieved with the methods already present. Maybe in a later step we can add them also here.

@codecov-io
Copy link

codecov-io commented Oct 29, 2020

Codecov Report

Merging #63 into main will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main       #63   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           31        32    +1     
  Lines         1249      1296   +47     
  Branches       161       167    +6     
=========================================
+ Hits          1249      1296   +47     
Impacted Files Coverage Δ
dask_sql/java.py 100.00% <ø> (ø)
dask_sql/context.py 100.00% <100.00%> (ø)
dask_sql/input_utils.py 100.00% <100.00%> (ø)
dask_sql/physical/rel/custom/create.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff117c8...0f28186. Read the comment docs.

@raybellwaves raybellwaves mentioned this pull request Oct 30, 2020
2 tasks
@nils-braun
Copy link
Collaborator Author

The PR contains a first experimental implementation of an hive input.
It is not really well tested so far (and I have also not written unittests for it) - so I guess this part should be improved in the next release.

@nils-braun nils-braun changed the title [WIP] Unify dask-sql API with blazing SQL Unify dask-sql API with blazing SQL Nov 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unify the API of dask-sql and blazing-sql
2 participants