Add support for CREATE EXPERIMENT, expand support for WITH kwargs
#796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charlesbluca
commented
Sep 22, 2022
dask_planner/src/parser.rs
Outdated
Comment on lines
154
to
158
| Value::Boolean(value) => Ok(if *value { | ||
| "1".to_string() | ||
| } else { | ||
| "".to_string() | ||
| }), |
There was a problem hiding this comment.
This is somewhat unclear mapping of booleans to strings is motivated by the fact that in Python, only empty strings are falsey (e.g. bool("False") == True); not sure if this serves as motivation to break up getSqlValue into several functions for the various different literal types.
Codecov Report
@@ Coverage Diff @@
## main #796 +/- ##
==========================================
+ Coverage 74.88% 77.18% +2.29%
==========================================
Files 71 71
Lines 3588 3594 +6
Branches 748 632 -116
==========================================
+ Hits 2687 2774 +87
+ Misses 771 687 -84
- Partials 130 133 +3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
gpuCI failures here are unrelated - working on a fix in #802 |
charlesbluca
requested review from
ayushdg,
galipremsagar and
jdye64
as code owners
andygrove
reviewed
Sep 23, 2022
andygrove
reviewed
Sep 23, 2022
andygrove
reviewed
Sep 23, 2022
andygrove
reviewed
Sep 23, 2022
Co-authored-by: Andy Grove <andygrove73@gmail.com>
andygrove
reviewed
Oct 7, 2022
|
|
||
| #[pyclass(name = "SqlArg", module = "datafusion")] | ||
| #[derive(Debug, Clone, PartialEq, Eq)] | ||
| pub struct PySqlArg { |
There was a problem hiding this comment.
This looks like it should be an enum instead of a struct?
andygrove
approved these changes
Oct 7, 2022
|
rerun tests |
ayushdg
approved these changes
Oct 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A continuation of @ChrisJar's work in #752; implements the basic plumbing for
CREATE EXPERIMENT, and adds aPySqlArgstruct to parser.rs that should allow us to parse nested kwargs in statements that useWITH.