Resolve test_date_functions()
#813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
sarahyurick
commented
Sep 27, 2022
sarahyurick
commented
- Extract microseconds/millennium/millisecond
- Last_day
- Timestampadd
- Ceil
- Floor
sarahyurick
requested review from
ayushdg,
charlesbluca and
galipremsagar
as code owners
ayushdg
reviewed
Sep 28, 2022
sarahyurick
commented
Sep 30, 2022
sarahyurick
commented
Sep 30, 2022
sarahyurick
commented
Oct 14, 2022
| fn parse_prefix(&self, parser: &mut Parser) -> Option<Result<Expr, ParserError>> { | ||
| fn parse_expr(parser: &mut Parser) -> Result<Option<Expr>, ParserError> { | ||
| match parser.peek_token() { | ||
| Token::Word(w) if w.value.to_lowercase() == "timestampadd" => { |
Codecov Report
@@ Coverage Diff @@
## main #813 +/- ##
==========================================
+ Coverage 75.91% 76.64% +0.72%
==========================================
Files 73 73
Lines 4082 4115 +33
Branches 739 751 +12
==========================================
+ Hits 3099 3154 +55
+ Misses 823 786 -37
- Partials 160 175 +15
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
sarahyurick
changed the title
test_date_functions()test_date_functions()
sarahyurick
commented
Oct 19, 2022
Co-authored-by: Charles Blackmon-Luca <20627856+charlesbluca@users.noreply.github.com>
charlesbluca
approved these changes
Dec 1, 2022
There was a problem hiding this comment.
Thanks @sarahyurick! Overall LGTM, just some small nitpicks
Co-authored-by: Charles Blackmon-Luca <20627856+charlesbluca@users.noreply.github.com>
ayushdg
reviewed
Dec 2, 2022
Comment on lines
+693
to
+700
| for date in df: | ||
| year = date.year + interval | ||
| # Check leap day | ||
| if year % 4 != 0 and date.month == 2 and date.day == 29: | ||
| result.append(date.replace(year=year, month=3, day=1)) | ||
| else: | ||
| result.append(date.replace(year=year)) | ||
| return pd.Series(result) |
There was a problem hiding this comment.
Is there an alternative approach that can achieve this without iterating over each row individually and specifically return a pandas series?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.