Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove np.float in PyTest and skip new NumPy failures #977

Merged
merged 3 commits into from
Dec 31, 2022
Merged

Remove np.float in PyTest and skip new NumPy failures #977

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a3bcc5d
use np.float64 instead of np.float
sarahyurick Dec 21, 2022
e7c4878
skip tpot tests
sarahyurick Dec 21, 2022
648732e
link to randomstate issue
sarahyurick Dec 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/integration/test_function.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ def f(row, k1, k2):
c.register_function(
f,
"f",
[("a", np.float), ("k1", const_type_k1), ("k2", const_type_k2)],
[("a", np.float64), ("k1", const_type_k1), ("k2", const_type_k2)],
retty,
row_udf=True,
)
Expand Down
2 changes: 2 additions & 0 deletions tests/integration/test_model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -899,6 +899,7 @@ def test_ml_experiment(c, client, training_df):

# TODO - many ML tests fail on clusters without sklearn - can we avoid this?
@skip_if_external_scheduler
@pytest.mark.skip(reason="Waiting on https://github.com/EpistasisLab/tpot/pull/1280")
def test_experiment_automl_classifier(c, client, training_df):
tpot = pytest.importorskip("tpot", reason="tpot not installed")
# currently tested with tpot==
Expand All @@ -924,6 +925,7 @@ def test_experiment_automl_classifier(c, client, training_df):

# TODO - many ML tests fail on clusters without sklearn - can we avoid this?
@skip_if_external_scheduler
@pytest.mark.skip(reason="Waiting on https://github.com/EpistasisLab/tpot/pull/1280")
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TPOT fails with the newest NumPy version as well. I've opened EpistasisLab/tpot#1280 to resolve this.

def test_experiment_automl_regressor(c, client, training_df):
tpot = pytest.importorskip("tpot", reason="tpot not installed")
# test regressor
Expand Down
3 changes: 3 additions & 0 deletions tests/integration/test_rex.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
import pandas as pd
import pytest

from tests.integration.fixtures import skip_if_external_scheduler
from tests.utils import assert_eq


Expand Down Expand Up @@ -140,6 +141,8 @@ def test_literal_null(c):
assert_eq(df, expected_df)


# TODO - https://github.com/dask-contrib/dask-sql/issues/978
@skip_if_external_scheduler
def test_random(c):
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opened #978

query_with_seed = """
SELECT
Expand Down