Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove np.float in PyTest and skip new NumPy failures #977

Merged
merged 3 commits into from
Dec 31, 2022

Conversation

sarahyurick
Copy link
Collaborator

NumPy 1.24.0 removed the np.float alias, so we have to replace np.float with np.float64 in PyTest test_custom_function_row_two_args.

Another option is to replace np.float with Python's float, although the NumPy version may be useful for consistency with NumPy arrays (source).

@@ -924,6 +925,7 @@ def test_experiment_automl_classifier(c, client, training_df):

# TODO - many ML tests fail on clusters without sklearn - can we avoid this?
@skip_if_external_scheduler
@pytest.mark.skip(reason="Waiting on https://github.com/EpistasisLab/tpot/pull/1280")
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TPOT fails with the newest NumPy version as well. I've opened EpistasisLab/tpot#1280 to resolve this.

@codecov-commenter
Copy link

codecov-commenter commented Dec 21, 2022

Codecov Report

Merging #977 (648732e) into main (4298d4d) will decrease coverage by 0.36%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #977      +/-   ##
==========================================
- Coverage   77.70%   77.34%   -0.37%     
==========================================
  Files          75       75              
  Lines        4235     4233       -2     
  Branches      772      765       -7     
==========================================
- Hits         3291     3274      -17     
- Misses        774      783       +9     
- Partials      170      176       +6     
Impacted Files Coverage Δ
dask_sql/physical/rel/custom/create_experiment.py 89.74% <0.00%> (-6.42%) ⬇️
dask_sql/physical/rex/core/literal.py 58.09% <0.00%> (-2.86%) ⬇️
dask_sql/physical/rel/logical/window.py 95.37% <0.00%> (-1.74%) ⬇️
dask_sql/_version.py 32.76% <0.00%> (-1.13%) ⬇️
dask_sql/physical/rel/custom/predict.py 75.00% <0.00%> (-0.68%) ⬇️
dask_sql/utils.py 99.03% <0.00%> (-0.01%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@@ -140,6 +141,8 @@ def test_literal_null(c):
assert_eq(df, expected_df)


# TODO - https://github.com/dask-contrib/dask-sql/issues/978
@skip_if_external_scheduler
def test_random(c):
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opened #978

@sarahyurick sarahyurick changed the title Remove np.float in PyTest Remove np.float in PyTest and skip new NumPy failures Dec 21, 2022
@ayushdg ayushdg merged commit 00562cd into dask-contrib:main Dec 31, 2022
@sarahyurick sarahyurick deleted the remove_npfloat branch May 26, 2023 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants