-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove np.float
in PyTest and skip new NumPy failures
#977
Conversation
@@ -924,6 +925,7 @@ def test_experiment_automl_classifier(c, client, training_df): | |||
|
|||
# TODO - many ML tests fail on clusters without sklearn - can we avoid this? | |||
@skip_if_external_scheduler | |||
@pytest.mark.skip(reason="Waiting on https://github.com/EpistasisLab/tpot/pull/1280") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TPOT fails with the newest NumPy version as well. I've opened EpistasisLab/tpot#1280 to resolve this.
Codecov Report
@@ Coverage Diff @@
## main #977 +/- ##
==========================================
- Coverage 77.70% 77.34% -0.37%
==========================================
Files 75 75
Lines 4235 4233 -2
Branches 772 765 -7
==========================================
- Hits 3291 3274 -17
- Misses 774 783 +9
- Partials 170 176 +6
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@@ -140,6 +141,8 @@ def test_literal_null(c): | |||
assert_eq(df, expected_df) | |||
|
|||
|
|||
# TODO - https://github.com/dask-contrib/dask-sql/issues/978 | |||
@skip_if_external_scheduler | |||
def test_random(c): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Opened #978
np.float
in PyTestnp.float
in PyTest and skip new NumPy failures
NumPy 1.24.0 removed the
np.float
alias, so we have to replacenp.float
withnp.float64
in PyTesttest_custom_function_row_two_args
.Another option is to replace
np.float
with Python'sfloat
, although the NumPy version may be useful for consistency with NumPy arrays (source).