-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 2021.05.0 #155
Comments
Should we hot-fix the existing packages to put a lower bound on click version? Apparently these are causing people issues as well cc @quasiben |
Sure, pinning |
Sounds good. Submitted PR ( conda-forge/conda-forge-repodata-patches-feedstock#142 ) to fix the repodata and PR ( conda-forge/distributed-feedstock#165 ) to fix the current package Unfortunately PyPI doesn't have a concept of repodata that I know of. So aside from yanking old packages there is not much we can do |
Following up on #150 (comment) and dask/distributed#4819, should we try pinning FWIW I brought this up a recent maintainers meeting and there were no objections to pinning @jakirkham @quasiben @kkraus14 would this negatively impact RAPIDS? EDIT: My preference is to try pinning more tightly |
I just saw dask/distributed#4820 and can't tell if it is an issue that needs to be solved before the release |
I does not sound like a new issue, but would be worth someone's while to see if it worked with older versions. |
It looks like a usage issue. The code should Edit: James pointed out this traces back to an older issue that was raised previously in 2019. In it Jim outlines what would be needed to do to improve the situation ( dask/dask#5518 (comment) ) as well as why it doesn't work today. Presumably this issue has existed as long as the |
Re: dask/distributed#4820 I agree that's a longstanding issue, and there's certainly room for improvement, but it shouldn't be a blocker for releasing. Re: version pinning, I spoke with @quasiben offline and he mentioned pinning
If this goes well, then we should continue to bump |
Alright, I'm going to starting pushing out this release |
|
Hi there — forgive asking on the old issue — but given the discussion above, is it also inadvisable to run say 2021.05.0 with 2021.06.0? Or is that in general OK? |
In general you should try to match versions.
…On Sat, Jun 19, 2021 at 8:34 PM Maximilian Roos ***@***.***> wrote:
Hi there — forgive asking on the old issue — but given the discussion
above, is it also inadvisable to run say 2021.05.0 with 2021.06.0? Or is
that in general OK?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#155 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACKZTF4BSCPHHYBT72X5GTTTVAT3ANCNFSM442VQE2Q>
.
|
I'd like to release
dask
anddistributed
2021.05.0 this Friday. In particular it would be nice to get dask/distributed#4810 out to users.Additionally:
would also be good to include in the relase
cc @jakirkham @jsignell @kkraus14
The text was updated successfully, but these errors were encountered: