-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci] pin dask and distributed in CI jobs #4288
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the fast fix!
Just curios: maybe you know why they have switched from semantic versioning to the date-based (or how is it called) one? LightGBM/python-package/setup.py Lines 346 to 349 in adf36d7
|
Ah, yep! They call this calver ("calendar versioning"). I remember the main discussion was in this issue: dask/community#100. It's a bit hard for me to follow the conversation there since it also references prior conversations, but I think this comment from dask/community#93 (comment) is probably close to the reason they decided to adopt calver:
|
Ooooh, "nice"!
They have already dropped support for Python 3.6. FYI, dependabot will be able to handle such cases with slight workarounds: For now, I'm not sure what to do... Maybe temporarily pin to the latest version with Python 3.6 support? |
Ah! I forgot about that! There was some discussion last year about it in dask/community#66. Seems that
I'll fix this PR to change the pin on 3.6. I believe that if we just remove pinning conda will handle providing the latest version that works with 3.6 for us. Seems like all Python 3.6 jobs on #4283, for example, succeeded without the For example, on
|
Thank you! Seems that according to dask/community#155 (comment) versions will be pinned internally and we will be able to revert this workaround quite soon 🙂 . |
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>
A bunch of the R jobs and the CUDA 10.0 job failed because of what looks like a brief outage on GitLab (where we get the Eigen submodule from)
I've restarted them manually |
Ok seems this worked! And I double-checked the logs from the most recent builds to be sure the Dask tests are running everywhere we expect them to. All looks ok. |
This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
This PR is a temporary fix to unblock continuous integration jobs in this project, which are currently blocked by #4285.