ci: let flake8 be configured in a single place instead of three #497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
consideRatio
commented
Mar 25, 2022
Comment on lines
-4
to
-6
| versioneer.py, | ||
| _version.py, | ||
| dask_gateway_config.py |
There was a problem hiding this comment.
- versioneer.py isn't used in this project
- dask_gateway_config.py may be generated, but is .gitignored as part of Add boilerplate .gitignore from GitHub #499
25 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I saw three configuration locations for flake8, each of which had the same configuration. Since pre-commit will be run and register the
.flake8configuration file in the git repo's root folder, I figure it made sense to avoid having multiple dupicates of this config.I also saw that the central .flake8 configuration mentioned two not existing files that wasn't .gitignored either, I assume they have been part of the repo but no longer are. Due to that, I figured it made sense to remove them as well.