Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require py39, k8s 1.24, use golang 1.21, update traefik from v2.9 to v2.10 #739

Merged

Conversation

consideRatio
Copy link
Collaborator

@consideRatio consideRatio commented Sep 22, 2023

  • Non-breaking: use golang 1.21 to compile dask-gateway-proxy
  • Dropping support for Python 3.8 as that is what dask/distributed and other packages has done already in the dask ecosystem.
  • Dropping support for k8s 1.23 and lower. For related discussions about things like this, see In Oct 2023 - drop support for k8s 1.23 jupyterhub/zero-to-jupyterhub-k8s#3042.
  • Upgrading the helm chart's traefik version from v2.9 to v2.10, which forces users upgrading the helm chart to also upgrade bundled CRD resources. A note is to be made in the changelog about doing kubectl apply before ugprading as has been done for previous releases when this has become needed.

@consideRatio consideRatio changed the title Require py39, k8s 1.24, and use golang 1.21 to compile Require py39, k8s 1.24, use golang 1.21, update traefik from v2.9 to v2.10 Sep 22, 2023
@consideRatio consideRatio force-pushed the pr/require-py38-k8s-1.24-use-golang1.21 branch 3 times, most recently from 4877a6d to 8f62dad Compare September 22, 2023 07:48
@consideRatio consideRatio force-pushed the pr/require-py38-k8s-1.24-use-golang1.21 branch 5 times, most recently from 4ba280a to b598571 Compare September 22, 2023 13:27
@consideRatio consideRatio force-pushed the pr/require-py38-k8s-1.24-use-golang1.21 branch 3 times, most recently from 3145ea2 to aaa027d Compare September 22, 2023 15:41
@consideRatio
Copy link
Collaborator Author

consideRatio commented Sep 25, 2023

Thanks for reviewing @TomAugspurger!

I did a delayed self-review and realized a possible issue for existing clusters, but after reviewing it further I don't think its an issue - I believe existing clusters will continue to work well even if the dask-gateway helm chart is upgraded.

By adopting the some new stuff in traefik v2.10, the upgrade to traefik v3 at some time in the future will be less disruptive though - as clusters created with traefik v2.9 (but not v2.10) would need to be re-created before traefik v3 is used.

Without objections by tomorrow, I'll go for a merge and cut a release. As can be seen from f2e0e48, its not much that we've done, but there are some bugfixes and a new feature for the helm chart.

@consideRatio consideRatio merged commit cfc19bd into dask:main Sep 26, 2023
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants