Skip to content

Commit

Permalink
Switch to use_stdin=True by default for LSFCluster. (#388)
Browse files Browse the repository at this point in the history
  • Loading branch information
lesteve committed Mar 5, 2020
1 parent 7e91119 commit 450aed4
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 3 deletions.
2 changes: 1 addition & 1 deletion dask_jobqueue/jobqueue.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ jobqueue:
job-extra: []
log-directory: null
lsf-units: null
use-stdin: null # (bool) How jobs are launched, i.e. 'bsub jobscript.sh' or 'bsub < jobscript.sh'
use-stdin: True # (bool) How jobs are launched, i.e. 'bsub jobscript.sh' or 'bsub < jobscript.sh'

htcondor:
name: dask-worker
Expand Down
2 changes: 0 additions & 2 deletions dask_jobqueue/lsf.py
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,6 @@ def __init__(

if use_stdin is None:
use_stdin = dask.config.get("jobqueue.%s.use-stdin" % self.config_name)
if use_stdin is None:
use_stdin = lsf_version() < "10"
self.use_stdin = use_stdin

header_lines = []
Expand Down
1 change: 1 addition & 0 deletions docs/source/changelog.rst
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ Development version
of threads per process is roughly the same. Old default was to use one
process and only threads, i.e. ``proccesses=1``, ``threads_per_process=cores``.
- fix bug (forgotten async def) in ``OARCluster._submit_job`` (:pr:`380`).
- ``LSFCluster``: switch to ``use_stdin=True`` (:pr:`388`).

0.7.0 / 2019-10-09
------------------
Expand Down

0 comments on commit 450aed4

Please sign in to comment.