Merged
Conversation
guillaumeeb
reviewed
Sep 22, 2018
Member
guillaumeeb
left a comment
guillaumeeb
left a comment
There was a problem hiding this comment.
Ok, I'm probably being too meticulous, but I would prefer to have the int() call around math.ceil(). Does this makes sens to you?
Contributor
Author
|
Moved. Your code base your call. LMK if/how you'd prefer this orchestrated if a single commit is significantly preferred. |
Member
|
We're squashing commits upon merge, so it's fine. I haven't checked #157 Travis output, but if It correctly catched the bug fixed here, It would ne good to retrigger the Travis check with an empty commit for example. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixed the type error for me in python 2.7. I'll work on and submit the CI fixes in a seperate PR.