Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #154 #155

Merged
merged 2 commits into from Sep 22, 2018
Merged

Fix issue #154 #155

merged 2 commits into from Sep 22, 2018

Conversation

@kaelancotter
Copy link
Contributor

@kaelancotter kaelancotter commented Sep 21, 2018

This fixed the type error for me in python 2.7. I'll work on and submit the CI fixes in a seperate PR.

Copy link
Member

@guillaumeeb guillaumeeb left a comment

Ok, I'm probably being too meticulous, but I would prefer to have the int() call around math.ceil(). Does this makes sens to you?

@kaelancotter
Copy link
Contributor Author

@kaelancotter kaelancotter commented Sep 22, 2018

Moved. Your code base your call. LMK if/how you'd prefer this orchestrated if a single commit is significantly preferred.

@guillaumeeb guillaumeeb merged commit 3aa3977 into dask:master Sep 22, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@guillaumeeb
Copy link
Member

@guillaumeeb guillaumeeb commented Sep 22, 2018

We're squashing commits upon merge, so it's fine. I haven't checked #157 Travis output, but if It correctly catched the bug fixed here, It would ne good to retrigger the Travis check with an empty commit for example.

@kaelancotter kaelancotter deleted the kaelancotter:fix_py27_core_typeerror branch Sep 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants