Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use dask.utils.tmpfile as distributed.utils.tmpfile was deprecated #529

Merged
merged 1 commit into from Nov 1, 2021

Conversation

riedel
Copy link
Member

@riedel riedel commented Oct 30, 2021

Fixes #528

@riedel riedel changed the title use dask.utils.temporary as distributed.utils.temporary was deprecated use dask.utils.tmpfile as distributed.utils.tmpfile was deprecated Oct 30, 2021
Copy link
Member

@andersy005 andersy005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍🏽

@andersy005
Copy link
Member

Do we need to update the version requirement for dask or does this work with our existing version requirement?

@riedel
Copy link
Member Author

riedel commented Oct 30, 2021

Do we need to update the version requirement for dask or does this work with our existing version requirement?

Should be OK:
https://github.com/dask/dask/blob/c48623bcd6e5fd7699b15c0e611ee38fff167ff6/dask/utils.py#L103-L118

@riedel
Copy link
Member Author

riedel commented Oct 30, 2021

@andersy005 : you might have made a point, but it was not me: #530

Copy link
Member

@guillaumeeb guillaumeeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @riedel for all your involvement!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

distributed.utils.tmpfile used in core.py to create the jobscript is deprecated
3 participants