basic sge implementation #6
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrocklin
reviewed
Mar 2, 2018
dask_jobqueue/sge.py
Outdated
| self.n = 0 | ||
| self._adaptive = None | ||
| self._submitcmd = 'qsub' | ||
| self._cancelcmd = 'qdel' |
There was a problem hiding this comment.
These should maybe be class variables?
There was a problem hiding this comment.
Yep, agree for submit and cancel commands.
| project = project or os.environ.get('SGE_ACCOUNT') | ||
| if not project: | ||
| raise ValueError("Must specify a project like `project='UCLB1234' " | ||
| "or set SGE_ACCOUNT environment variable") |
|
|
||
| def test_basic(loop): | ||
| with SGECluster(walltime='00:02:00', threads_per_worker=2, memory='7GB', | ||
| interface='ib0', loop=loop) as cluster: |
There was a problem hiding this comment.
The interface keyword option here will likely fail on a CI system.
So Travis CI is enabled, but does not have a configuration file yet. Would encourage just stealing stuff from |
|
Thanks I'll try to take a look. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #3
I don't think this is ready to merge. Turns out the SGE cluster I used to have access to is no more. Perhaps we should get a basic CI implementation setup before pushing more content into the repo?