Generalise submission and cancellation arguments #641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I found that the HTCondor class already had something similar. I've added this to the base I've reworked the |
AlecThomson
changed the title
guillaumeeb
reviewed
May 31, 2024
dask_jobqueue/lsf.py
Outdated
| @@ -54,6 +55,28 @@ def __init__( | |||
| use_stdin = dask.config.get("jobqueue.%s.use-stdin" % self.config_name) | |||
| self.use_stdin = use_stdin | |||
|
|
|||
| if self.submit_command_extra is None: | |||
There was a problem hiding this comment.
Why is all this code both in the Core class and the class inheriting it?
|
Also, the test failures in slurm (and maybe others) looks related to this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #640