Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use default scheduler sniffing logic from dask #260

Merged
merged 3 commits into from Jul 3, 2018

Conversation

Projects
None yet
2 participants
@mrocklin
Copy link
Member

mrocklin commented Jul 2, 2018

This removes the _normalize_scheduler function from dask_searchcv and
some of the scheduling names (threaded, sequential) and replaces them
with the Dask logic.

This both unifies logic across projects and also lets the distributed
scheduler take over when it is set as default.

Fixes #249

mrocklin added some commits Jul 2, 2018

Use default scheduler sniffing logic from dask
This removes the _normalize_scheduler function from dask_searchcv and
some of the scheduling names (threaded, sequential) and replaces them
with the Dask logic.

This both unifies logic across projects and also lets the distributed
scheduler take over when it is set as default.

Fixes #249
@TomAugspurger

This comment has been minimized.

Copy link
Member

TomAugspurger commented Jul 3, 2018

All green, thanks!

@TomAugspurger TomAugspurger merged commit b21d4fd into dask:master Jul 3, 2018

3 checks passed

ci/circleci: py27 Your tests passed on CircleCI!
Details
ci/circleci: py36 Your tests passed on CircleCI!
Details
ci/circleci: sklearn_dev Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.