Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize documentation #30

Merged
merged 14 commits into from
Oct 13, 2017
Merged

Reorganize documentation #30

merged 14 commits into from
Oct 13, 2017

Conversation

mrocklin
Copy link
Member

This breaks out sections based on algorithm type rather than on
single/distributed.

Fixes #29

This still needs substantial work, both in fixing up API docs and
fleshing out content in the various sections.

I've pushed this to the dask fork rather than my own as a signal that others are more than welcome to collaborate on this.

@mrocklin
Copy link
Member Author

Your review of recent changes would be welcome @TomAugspurger

Copy link
Member

@TomAugspurger TomAugspurger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good, thanks.

@@ -0,0 +1 @@
from dask_xgboost import * # noqa
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thoughts on making xgboost optional? AFAICT, xgboost doesn't upload wheels.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that it is. We don't import this in daskml/__init__

used by the Scikit Learn community. As of version 0.10.0 it contains a plugin
mechanism to allow Joblib code to use other parallel frameworks to execute
computations. The ``dask.distributed`` scheduler implements such a plugin in
the ``distributed.joblib`` module and registers it appropriately with Joblib.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add, "when imported".

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved

@TomAugspurger TomAugspurger mentioned this pull request Oct 13, 2017
also add imported text in joblib
@mrocklin mrocklin merged commit 91d7735 into master Oct 13, 2017
@mrocklin mrocklin deleted the update-docs branch October 13, 2017 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs reorganization
2 participants