-
-
Notifications
You must be signed in to change notification settings - Fork 255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reorganize documentation #30
Conversation
This breaks out sections based on algorithm type rather than on single/distributed. Fixes #29 This still needs substantial work, both in fixing up API docs and fleshing out content in the various sections.
Your review of recent changes would be welcome @TomAugspurger |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really good, thanks.
@@ -0,0 +1 @@ | |||
from dask_xgboost import * # noqa |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thoughts on making xgboost optional? AFAICT, xgboost doesn't upload wheels.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that it is. We don't import this in daskml/__init__
docs/source/joblib.rst
Outdated
used by the Scikit Learn community. As of version 0.10.0 it contains a plugin | ||
mechanism to allow Joblib code to use other parallel frameworks to execute | ||
computations. The ``dask.distributed`` scheduler implements such a plugin in | ||
the ``distributed.joblib`` module and registers it appropriately with Joblib. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe add, "when imported".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resolved
also add imported text in joblib
This breaks out sections based on algorithm type rather than on
single/distributed.
Fixes #29
This still needs substantial work, both in fixing up API docs and
fleshing out content in the various sections.
I've pushed this to the
dask
fork rather than my own as a signal that others are more than welcome to collaborate on this.