Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove circular import when dask-expr enabled #10824

Merged

Conversation

milesgranger
Copy link
Contributor

@milesgranger milesgranger commented Jan 18, 2024

Reload dask.dataframe on ImportError


Edit, woops, duplicate of #10822

@milesgranger milesgranger force-pushed the milesgranger/706-circular-import-dask-expr branch from 41bfed4 to c87e317 Compare January 18, 2024 09:17
@milesgranger milesgranger changed the title Remove circular import from dask-expr enabled Remove circular import when dask-expr enabled Jan 18, 2024
@milesgranger milesgranger force-pushed the milesgranger/706-circular-import-dask-expr branch from c87e317 to 4c89db8 Compare January 18, 2024 09:24
Copy link
Contributor

github-actions bot commented Jan 18, 2024

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

     15 files       15 suites   3h 14m 55s ⏱️
 12 911 tests  11 963 ✅    929 💤 19 ❌
159 969 runs  143 378 ✅ 16 572 💤 19 ❌

For more details on these failures, see this check.

Results for commit 3347001.

♻️ This comment has been updated with latest results.

@milesgranger milesgranger force-pushed the milesgranger/706-circular-import-dask-expr branch from 4c89db8 to 3347001 Compare January 18, 2024 13:17
@phofl phofl merged commit 1b384b4 into dask:main Jan 18, 2024
27 of 28 checks passed
@phofl
Copy link
Collaborator

phofl commented Jan 18, 2024

thx @milesgranger

@milesgranger milesgranger deleted the milesgranger/706-circular-import-dask-expr branch January 18, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants