Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor[CI]: publish-test-results not marked as failed #10825

Conversation

milesgranger
Copy link
Contributor

Change the publish unit test result action to not report itself as failed if other tests in CI have failed, only on errors.

Rationale:
PRs like #10824 get the ugly ❌ when any tests fail b/c the action itself reports itself as failed when any tests in the CI has failed.

However, "nothing" in the PR has failed, only tests for dask-expr which are expected and thus marked green on CI.
https://github.com/dask/dask/actions/runs/7567879416/job/20607928150?pr=10824#step:8:28559

Copy link
Contributor

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

     15 files  ±0       15 suites  ±0   3h 29m 23s ⏱️ - 9m 31s
 12 911 tests ±0   11 958 ✅  - 1     929 💤 ±0  24 ❌ +1 
159 969 runs  ±0  143 379 ✅ +3  16 566 💤  - 4  24 ❌ +1 

For more details on these failures, see this check.

Results for commit 33afda7. ± Comparison against base commit 6b76a5a.

@milesgranger milesgranger marked this pull request as draft January 18, 2024 12:00
@milesgranger
Copy link
Contributor Author

Note the changes aren't reflected until in main.
I've tested this on my fork here: milesgranger#5 (merged this PR in my fork w/ a test PR)

@milesgranger milesgranger marked this pull request as ready for review January 18, 2024 13:12
@phofl phofl merged commit e72f93e into dask:main Jan 18, 2024
27 of 29 checks passed
@phofl
Copy link
Collaborator

phofl commented Jan 18, 2024

thx, lets try it

@milesgranger milesgranger deleted the milesgranger/publish-test-result-not-marked-failed branch January 18, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants