New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dask config set
#10921
Add dask config set
#10921
Conversation
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 15 files ± 0 15 suites ±0 3h 24m 46s ⏱️ + 5m 59s Results for commit 2804fab. ± Comparison against base commit 76b255e. ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new command dumps out your whole dask config to ~/.config/dask/dask.yaml
.
I would like to treat this as an antipattern, as it will cause many problems down the line when some developer changes a default of some obscure setting but the users don't pick up the change. What's worse, wiping and rebuilding the conda environment won't reflect the change. Also, the user will have no indication, when they do open that config file, about which settings were their own intentional changes from a month before and which were just copy-pasted defaults.
Could you change the code to add the new explicit config override to whatever was already there in ~/.config/dask/dask.yaml
, but nothing in addition to that?
Finally, could you document the new command in docs/source/configuration.rst
?
90df0ad
to
b58cdfd
Compare
Thanks for the review @crusaderky, clearly the CLI will take a bit more work, so I've moved the config option over to #10925.
Indeed, I wasn't sure if this was correct either but saw this is the same flow being done with |
dask config set
eb3df34
to
0b40656
Compare
0b40656
to
de31dd2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you document the new command in docs/source/configuration.rst?
Everything else LGTM
e9f643b
to
2804fab
Compare
pre-commit run --all-files
dask config set dataframe.query-planning-warning False
.