[CLI] dask config set and dask config find updates.#10930
Merged
crusaderky merged 17 commits intodask:mainfrom Feb 19, 2024
Merged
[CLI] dask config set and dask config find updates.#10930crusaderky merged 17 commits intodask:mainfrom
dask config set and dask config find updates.#10930crusaderky merged 17 commits intodask:mainfrom
Conversation
Contributor
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 15 files ± 0 15 suites ±0 3h 18m 18s ⏱️ -20s Results for commit aa7e7dc. ± Comparison against base commit 7845983. This pull request removes 8 and adds 62 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
crusaderky
reviewed
Feb 16, 2024
crusaderky
reviewed
Feb 16, 2024
crusaderky
reviewed
Feb 16, 2024
crusaderky
reviewed
Feb 16, 2024
crusaderky
reviewed
Feb 16, 2024
crusaderky
reviewed
Feb 16, 2024
crusaderky
reviewed
Feb 16, 2024
crusaderky
reviewed
Feb 16, 2024
crusaderky
reviewed
Feb 16, 2024
crusaderky
reviewed
Feb 16, 2024
crusaderky
reviewed
Feb 16, 2024
crusaderky
requested changes
Feb 16, 2024
Collaborator
crusaderky
left a comment
There was a problem hiding this comment.
Some minor suggestions.
A tweak that I'd like to see, to prevent confusion from the output of dask config find, is to print out the value in the default files embedded in the packages, if any.
This however can be postponed to a follow-up PR.
[skip ci] Co-authored-by: crusaderky <crusaderky@gmail.com>
Co-authored-by: crusaderky <crusaderky@gmail.com>
Co-authored-by: crusaderky <crusaderky@gmail.com>
Co-authored-by: crusaderky <crusaderky@gmail.com>
Co-authored-by: crusaderky <crusaderky@gmail.com>
Co-authored-by: crusaderky <crusaderky@gmail.com>
Co-authored-by: crusaderky <crusaderky@gmail.com>
def44ad to
d2c19cd
Compare
crusaderky
reviewed
Feb 19, 2024
Co-authored-by: crusaderky <crusaderky@gmail.com>
Member
|
cc @ntabris |
crusaderky
approved these changes
Feb 19, 2024
Collaborator
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dask config set#10921pre-commit run --all-filesExample of
dask config setnew features:Example of new
dask config find: