Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A few parquet cleanups #2867

Merged
merged 2 commits into from
Nov 7, 2017
Merged

A few parquet cleanups #2867

merged 2 commits into from
Nov 7, 2017

Conversation

jcrist
Copy link
Member

@jcrist jcrist commented Nov 6, 2017

  • Simplify logic in a few places
  • Remove unnecessary imports
  • Formatting tweaks
  • Reorder df and path arguments in to_parquet to be consistent with other output functions. Add a deprecation warning to remain backwards compatible with old methods.

- Logic simplification
- Remove a few unneeded imports
- Formatting cleanups
These didn't match the consistent ordering of `df, path` in other output
functions/methods. Add a deprecation warning to remain backwards
compatible.
@jcrist
Copy link
Member Author

jcrist commented Nov 6, 2017

Ping @martindurant for a quick review.

@jcrist
Copy link
Member Author

jcrist commented Nov 7, 2017

Planning on merging later today if no comment.

@martindurant
Copy link
Member

looks good

@jcrist jcrist merged commit acf4c4e into dask:master Nov 7, 2017
@jcrist jcrist deleted the to-parquet-cleanups branch November 7, 2017 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants