WIP: Add rollaxis #2955
Closed
WIP: Add rollaxis #2955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is still incomplete ATM. So will need some more work before it can be reviewed. |
jakirkham
force-pushed
the
add_rollaxis
branch
from
bd289f2
to
ca8098e
Compare
Uses `transpose` to swap axes.
Make `rollaxis` part of the Dask Array public API.
Provide some basic tests to compare the Dask Array and NumPy implementations of `rollaxis`.
Make sure the Dask Array API of `rollaxis` is documented.
|
Is it safe to close this PR as it's superseded by #4822? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses issue ( #2559 ).
Implements
rollaxisfor Dask Arrays. Addsrollaxisto the public API and documents it. Provides some tests ofrollaxisfrom Dask Array compared to NumPy.