read_sql_table - datetime index fix and index type checking #4474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you please add a test, in which a text column is chosen, and so it raises the exception? |
|
Yes, sure thing. I presume it would sit in here |
|
Yes exactly |
|
apologies for the delay - I have added a test which sets the index column to be a character column and checks for the TypeError exception. (first time I have written that sort of test, so I just mimicked what was in there already - hopefully it is along the right lines) |
|
Looks good, except lint: |
|
Ah, missed that step - should be good now. |
|
Thank you. |
jorge-pessoa
pushed a commit
to jorge-pessoa/dask
that referenced
this pull request
May 14, 2019
* switched /npartitions and total_seconds() * added check for type before creating divisions * removed comments * added test for character index type error * added blank line at end of file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4289
Also added a type check on the index column if
divisions is None. It will raise aTypeErrorif the index column'sdtype.kindis not in['i', 'u', 'f']or equal toMflake8 dask