Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added meta for read_json and test #4588

Merged
merged 2 commits into from May 1, 2019

Conversation

Projects
None yet
4 participants
@abhinavralhan
Copy link
Contributor

commented Mar 13, 2019

  • Tests added / passed
  • Passes flake8 dask

Closes #4553

@abhinavralhan

This comment has been minimized.

Copy link
Contributor Author

commented Mar 13, 2019

@TomAugspurger i raised a new PR since previous one got messy. please let me know if this is okay. thanks for patience.

value = val if not val % 2 else float('NaN')
json_string['dtype' + str(key)] = [val, value]
with pytest.raises(ValueError):
df = dd.read_json(json_string, orient=orient, meta=pd.DataFrame(json_string)[:0])

This comment has been minimized.

Copy link
@jrbourbeau

jrbourbeau Mar 21, 2019

Member

It appears tests are failing because you're passing a dictionary to dd.read_json (see https://travis-ci.org/dask/dask/jobs/505965158#L1796), which is expecting the location of the json file(s) to read (e.g. dd.read_json('path/to/myfile.json'))

You might try looking at dask/dataframe/io/tests/test_json.py to see how dd.read_json is used in the existing tests.

@jcrist jcrist self-assigned this Apr 30, 2019

@martindurant

This comment has been minimized.

Copy link
Member

commented Apr 30, 2019

@abhinavralhan , may I push to your branch?

@jcrist jcrist merged commit f96f14b into dask:master May 1, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

jorge-pessoa pushed a commit to jorge-pessoa/dask that referenced this pull request May 14, 2019

added meta for read_json and test (dask#4588)
* added meta for read_json and test

* fixups

Thomas-Z added a commit to Thomas-Z/dask that referenced this pull request May 17, 2019

added meta for read_json and test (dask#4588)
* added meta for read_json and test

* fixups
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.