added meta for read_json and test #4588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@TomAugspurger i raised a new PR since previous one got messy. please let me know if this is okay. thanks for patience. |
jrbourbeau
reviewed
Mar 21, 2019
dask/dataframe/io/tests/test_json.py
Outdated
| value = val if not val % 2 else float('NaN') | ||
| json_string['dtype' + str(key)] = [val, value] | ||
| with pytest.raises(ValueError): | ||
| df = dd.read_json(json_string, orient=orient, meta=pd.DataFrame(json_string)[:0]) |
There was a problem hiding this comment.
It appears tests are failing because you're passing a dictionary to dd.read_json (see https://travis-ci.org/dask/dask/jobs/505965158#L1796), which is expecting the location of the json file(s) to read (e.g. dd.read_json('path/to/myfile.json'))
You might try looking at dask/dataframe/io/tests/test_json.py to see how dd.read_json is used in the existing tests.
|
@abhinavralhan , may I push to your branch? |
jorge-pessoa
pushed a commit
to jorge-pessoa/dask
that referenced
this pull request
May 14, 2019
* added meta for read_json and test * fixups
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
flake8 daskCloses #4553