Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Warn if partitions overlap in compute_divisions #4600
On Fri, Mar 15, 2019 at 11:56 PM Brian Chu ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In dask/dataframe/tests/test_shuffle.py <#4600 (comment)>: > @@ -602,6 +602,9 @@ def test_set_index_sorted_true(): with pytest.raises(ValueError): a.set_index(a.z, sorted=True) + with pytest.raises(ValueError): + a.set_index(a.y, sorted=True) Seems pretty complicated. :) Perhaps I could just change this to a warning. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#4600 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AASszA8EkaMDRJCDg26Rm6--TMiWIElEks5vXJWFgaJpZM4b3dFn> .
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews.