Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix kurtosis calc for single dimension input array #5177

Merged
merged 8 commits into from
Jul 30, 2019
Merged

Fix kurtosis calc for single dimension input array #5177

merged 8 commits into from
Jul 30, 2019

Conversation

erdnaavlis
Copy link
Contributor

@erdnaavlis erdnaavlis commented Jul 30, 2019 •
edited
Loading

  • Tests added / passed
  • Passes black dask / flake8 dask

Fixes #5176

@erdnaavlis erdnaavlis mentioned this pull request Jul 30, 2019
Closed
@jcrist
Copy link
Member

jcrist commented Jul 30, 2019

Thanks for the PR, overall this seems fine to me. cc @TomAugspurger for a quick review since he's the last one to touch this code.

@TomAugspurger TomAugspurger merged commit a470c5d into dask:master Jul 30, 2019
@erdnaavlis erdnaavlis deleted the fix_kurtosis_calc_for_single_dimension_array branch July 31, 2019 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomAugspurger TomAugspurger TomAugspurger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

If Dask.array.stats.kurtosis input has ndim==1 the flag fisher is ignored and assumed to be always False
3 participants
@erdnaavlis @jcrist @TomAugspurger