Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Array: Fix stack error message #6268

Merged
merged 2 commits into from
Jun 2, 2020
Merged

Array: Fix stack error message #6268

merged 2 commits into from
Jun 2, 2020

Conversation

stephaniegott
Copy link
Contributor

@stephaniegott stephaniegott commented Jun 1, 2020 •
edited
Loading

  • Tests added / passed
  • Passes black dask / flake8 dask

Addresses #6199

jcrist
jcrist reviewed Jun 1, 2020
View reviewed changes
Copy link
Member

@jcrist jcrist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @stephaniegott! Just a few small suggestions.

Could you also add a test for this error? This would be updating the test here:

dask/dask/array/tests/test_array_core.py

Line 3620 in 9e994ba

def test_stack_errs():
to better check the error message.

dask/array/core.py Outdated Show resolved Hide resolved
dask/array/core.py Outdated Show resolved Hide resolved
jcrist
jcrist approved these changes Jun 2, 2020
View reviewed changes
Copy link
Member

@jcrist jcrist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, merging.

@jcrist jcrist merged commit 1d8e1e9 into dask:master Jun 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcrist jcrist jcrist approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stephaniegott @jcrist