map_partitions with review comments #6776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for keeping at it @kumarprabhu1988 - I think this is getting close. The missing piece now is docs. Could you add a section to the examples here: Line 574 in 9d19952 |
2 tasks
|
@jsignell Apologies for the delay. I've updated the docs. Let me know if this looks good. |
|
I really think the doc string should include an example using partition_info. Would you be able to add that? |
|
I'll merge this when it passes. |
|
Just merged |
|
Just checking in @jsignell, is this still good to go? |
abduhbm
pushed a commit
to abduhbm/dask
that referenced
this pull request
Jan 19, 2021
* map_partitions with review comments * update doc * Add example to docstring Co-authored-by: Julia Signell <jsignell@gmail.com> Co-authored-by: James Bourbeau <jrbourbeau@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds functionality to return partition_info in a call to map_partitions. It is useful for distributed implementations of many algorithms. This PR includes changes for review comments in this PR: #6755.
black dask/flake8 dask