Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to GitHub Actions #6794

Merged
merged 25 commits into from Nov 14, 2020

Conversation

jacobtomlinson
Copy link
Member

@jacobtomlinson jacobtomlinson commented Nov 3, 2020

Closes #6787

This PR migrates CI to GitHub Actions.

To do:

  • Run tests on all os/python combinations
  • Run nightly tests on upstream repos
  • Import checks
  • Mindeps checks
  • HDFS checks

Changes:

  • Coverage is only run on linux py38
  • All python versions are now tested on macos

@jacobtomlinson
Copy link
Member Author

I think this is ready now.

The mindeps and upstream tests are failing on my fork, but the failures are consistent with the existing failures in Travis. This should probably be investigated but is orthogonal to this migration.

@mrocklin
Copy link
Member

mrocklin commented Nov 4, 2020

Thank you for doing this @jacobtomlinson

@jakirkham or @quasiben is this something that you have time to take a look at? My guess is that you are more familiar with CI than most folks.

Copy link
Member

@jrbourbeau jrbourbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all your work on this @jacobtomlinson! I've left a few small-ish comments, but overall the changes here look good

.github/workflows/ci.yml Outdated Show resolved Hide resolved
jobs:
build:
runs-on: "ubuntu-latest"
if: "contains(github.event.head_commit.message, 'test-upstream') || github.event_name != 'pull_request'"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not 100% sure this is working as the upstream build was skipped for e5e2cd9 which includes "test-upstream" in the commit message

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It only works for the first commit in the PR (head_commit). I spent some time trying to figure out if you could trigger this on the latest commit on the branch but it doesn't seem the github.event object has this info.

continuous_integration/travis/install.sh Show resolved Hide resolved
.github/workflows/ci-additional.yml Outdated Show resolved Hide resolved
@jacobtomlinson
Copy link
Member Author

Thanks @jrbourbeau I've addressed the review feedback.

I've commented out the coverage for now. I would actually propose that we switch to codecov in future. I've had good experience in other projects and it handles combining coverage very well. So you run coverage on everywhere and codecov merges the reports, this would mean things like the HDFS tests would be included in coverage on master.

But as you say it would be good to address this later.

Copy link
Contributor

@gforsyth gforsyth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small changes for the migration from goanpeca -> conda-incubator org

.github/workflows/ci-additional.yml Outdated Show resolved Hide resolved
.github/workflows/ci-additional.yml Outdated Show resolved Hide resolved
.github/workflows/ci-upstream.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
Co-authored-by: Gil Forsyth <gforsyth@users.noreply.github.com>
Copy link
Member

@jrbourbeau jrbourbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all your work on this @jacobtomlinson!

@jrbourbeau jrbourbeau merged commit c27f33e into dask:master Nov 14, 2020
@jacobtomlinson
Copy link
Member Author

Thanks for the tweaks @gforsyth!

@jacobtomlinson jacobtomlinson deleted the migrate-to-github-actions branch November 16, 2020 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate CI to GitHub Actions
4 participants