Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to GitHub Actions #6794

Merged
merged 25 commits into from Nov 14, 2020
Merged
Show file tree
Hide file tree
Changes from 23 commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
43ab8ab
Migrate to GitHub Actions
jacobtomlinson Nov 3, 2020
a702137
Set PYTHON_VERSION
jacobtomlinson Nov 3, 2020
a8629b4
Debug import tests
jacobtomlinson Nov 3, 2020
5340a48
trigger test-hdfs test-mindeps
jacobtomlinson Nov 3, 2020
7fc2c71
Bump mindeps version
jacobtomlinson Nov 3, 2020
45aa3d8
Test again
jacobtomlinson Nov 3, 2020
9312895
Disable docker tty flag
jacobtomlinson Nov 3, 2020
7703b5c
Bump minimum Python to 3.7 as s3fs requires it
jacobtomlinson Nov 3, 2020
3d30848
Move imports tests to additional
jacobtomlinson Nov 3, 2020
3620d7a
Add YAML
jacobtomlinson Nov 3, 2020
0cd959d
Stop blackholing the output so we can see what is failing
jacobtomlinson Nov 4, 2020
2b38ba0
Add conda
jacobtomlinson Nov 4, 2020
66d5cee
Give HDFS a name
jacobtomlinson Nov 4, 2020
11eb361
Run tests in parallel
jacobtomlinson Nov 4, 2020
e5e2cd9
Enable upstream tests on master and PRs with test-upstream in commit
jacobtomlinson Nov 4, 2020
80084fe
Update CI badges to unified GHA CI
jacobtomlinson Nov 4, 2020
648a1b8
Quiet conda
jacobtomlinson Nov 5, 2020
b2969b9
Remove coverage environment variable
jrbourbeau Nov 12, 2020
d3c5d3d
Remove codecov (wasn't working on travis anyways)
jrbourbeau Nov 12, 2020
8487fc7
Run tests with coverage
jrbourbeau Nov 12, 2020
9b5efa5
Set parallel and coverage env vars
jrbourbeau Nov 12, 2020
9b9e684
Address review feedback
jacobtomlinson Nov 13, 2020
2b671e0
Merge branch 'migrate-to-github-actions' of github.com:jacobtomlinson…
jacobtomlinson Nov 13, 2020
dfcee7d
Apply suggestions from code review
jrbourbeau Nov 14, 2020
488921f
Comment out cityhash
jrbourbeau Nov 14, 2020
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
77 changes: 77 additions & 0 deletions .github/workflows/ci-additional.yml
@@ -0,0 +1,77 @@
name: CI Additional

on: [push, pull_request]

jobs:
mindeps:
runs-on: "ubuntu-latest"
if: "contains(github.event.head_commit.message, 'test-mindeps') || github.event_name != 'pull_request'"

strategy:
matrix:
environment: ["mindeps-array-dataframe", "mindeps-bag-delayed"]

steps:
- name: Checkout source
uses: actions/checkout@v2

- name: Setup Conda Environment
uses: goanpeca/setup-miniconda@v1.7.0
jrbourbeau marked this conversation as resolved.
Show resolved Hide resolved
with:
miniconda-version: "latest"
python-version: "3.7"
environment-file: continuous_integration/environment-${{ matrix.environment }}.yaml
activate-environment: test-environment
auto-activate-base: false

- name: Install
shell: bash -l {0}
run: source continuous_integration/scripts/install.sh

- name: Run tests
shell: bash -l {0}
run: source continuous_integration/scripts/run_tests.sh

hdfs:
runs-on: "ubuntu-latest"
if: "contains(github.event.head_commit.message, 'test-hdfs') || github.event_name != 'pull_request'"

steps:
- name: Checkout source
uses: actions/checkout@v2

- name: Start HDFS
shell: bash -l {0}
run: source continuous_integration/hdfs/startup_hdfs.sh

- name: Install
shell: bash -l {0}
run: source continuous_integration/hdfs/install.sh

- name: Run tests
shell: bash -l {0}
run: source continuous_integration/hdfs/run_tests.sh

imports:
runs-on: "ubuntu-latest"
strategy:
fail-fast: true
matrix:
python-version: ["3.6", "3.7", "3.8"]
steps:
- name: Checkout source
uses: actions/checkout@v2

- name: Setup Conda
uses: goanpeca/setup-miniconda@v1.7.0
jrbourbeau marked this conversation as resolved.
Show resolved Hide resolved
with:
miniconda-version: "latest"
python-version: "3.7"
activate-environment: test-environment
auto-activate-base: false

- name: Run import tests
shell: bash -l {0}
env:
PYTHON_VERSION: ${{ matrix.python-version }}
run: source continuous_integration/scripts/test_imports.sh
11 changes: 6 additions & 5 deletions .github/workflows/ci-pre-commit.yml
@@ -1,4 +1,4 @@
name: pre-commit
name: Linting

on:
push:
Expand All @@ -7,9 +7,10 @@ on:
branches: master

jobs:
build:
checks:
name: "pre-commit hooks"
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/setup-python@v2
- uses: pre-commit/action@v2.0.0
- uses: actions/checkout@v2
- uses: actions/setup-python@v2
- uses: pre-commit/action@v2.0.0
35 changes: 35 additions & 0 deletions .github/workflows/ci-upstream.yml
@@ -0,0 +1,35 @@
name: Upstream

on:
schedule:
- cron: "0 1 * * *"
push:
pull_request:

jobs:
build:
runs-on: "ubuntu-latest"
if: "contains(github.event.head_commit.message, 'test-upstream') || github.event_name != 'pull_request'"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not 100% sure this is working as the upstream build was skipped for e5e2cd9 which includes "test-upstream" in the commit message

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It only works for the first commit in the PR (head_commit). I spent some time trying to figure out if you could trigger this on the latest commit on the branch but it doesn't seem the github.event object has this info.


steps:
- name: Checkout source
uses: actions/checkout@v2

- name: Setup Conda Environment
uses: goanpeca/setup-miniconda@v1.7.0
jrbourbeau marked this conversation as resolved.
Show resolved Hide resolved
with:
miniconda-version: "latest"
python-version: 3.8
environment-file: continuous_integration/environment-3.8-dev.yaml
activate-environment: test-environment
auto-activate-base: false

- name: Install
shell: bash -l {0}
env:
UPSTREAM_DEV: 1
run: source continuous_integration/scripts/install.sh

- name: Run tests
shell: bash -l {0}
run: source continuous_integration/scripts/run_tests.sh
36 changes: 0 additions & 36 deletions .github/workflows/ci-windows.yaml

This file was deleted.

59 changes: 34 additions & 25 deletions .github/workflows/ci.yml
@@ -1,34 +1,43 @@
name: CI

on:
push:
branches: master
pull_request:
branches: master
on: [push, pull_request]

jobs:
checks:
name: Documentation build
runs-on: ubuntu-latest
steps:
test:
runs-on: ${{ matrix.os }}
strategy:
fail-fast: true
matrix:
os: ["windows-latest", "ubuntu-latest", "macos-latest"]
python-version: ["3.6", "3.7", "3.8"]

env:
PYTHON_VERSION: ${{ matrix.python-version }}
PARALLEL: "true"
COVERAGE: "false"

- name: Checkout
uses: actions/checkout@v2
steps:
- name: Checkout source
uses: actions/checkout@v2

- name: Set up Python 3.7
uses: actions/setup-python@v1
with:
python-version: 3.7
- name: Setup Conda Environment
uses: goanpeca/setup-miniconda@v1.7.0
jrbourbeau marked this conversation as resolved.
Show resolved Hide resolved
with:
miniconda-version: "latest"
python-version: ${{ matrix.python-version }}
environment-file: continuous_integration/environment-${{ matrix.python-version }}.yaml
activate-environment: test-environment
auto-activate-base: false

- name: Install Dask
run: |
python -m pip install --upgrade pip
python -m pip install -e .
- name: Install
shell: bash -l {0}
run: source continuous_integration/scripts/install.sh

- name: Install doc dependencies
run: python -m pip install -r docs/requirements-docs.txt
- name: Run tests
shell: bash -l {0}
run: source continuous_integration/scripts/run_tests.sh

- name: Build docs
run: |
cd docs
make html
# - name: Coverage
# shell: bash -l {0}
# if: ${{ matrix.os == 'ubuntu-latest' && matrix.python-version == '3.8' }}
# run: source continuous_integration/scripts/coverage.sh
33 changes: 33 additions & 0 deletions .github/workflows/docs.yml
@@ -0,0 +1,33 @@
name: Documentation

on:
push:
branches: master
pull_request:
branches: master

jobs:
checks:
name: build
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v2

- name: Set up Python 3.7
uses: actions/setup-python@v1
with:
python-version: 3.7

- name: Install Dask
run: |
python -m pip install --upgrade pip
python -m pip install -e .

- name: Install doc dependencies
run: python -m pip install -r docs/requirements-docs.txt

- name: Build docs
run: |
cd docs
make html
103 changes: 0 additions & 103 deletions .travis.yml

This file was deleted.