Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip empty partitions when doing groupby.value_counts #7073

Merged
merged 3 commits into from
Jan 20, 2021
Merged

Skip empty partitions when doing groupby.value_counts #7073

merged 3 commits into from
Jan 20, 2021

Conversation

jsignell
Copy link
Member

@jsignell jsignell commented Jan 15, 2021 •
edited
Loading

@jsignell
Copy link
Member Author

jsignell commented Jan 15, 2021 •
edited
Loading

@jrbourbeau this can probably get in, but no biggie if not. It'll go away with pandas-dev/pandas#39172

@jsignell @jrbourbeau
Update dask/dataframe/tests/test_groupby.py
bda4be9 
Co-authored-by: James Bourbeau <jrbourbeau@users.noreply.github.com>
jrbourbeau
jrbourbeau approved these changes Jan 20, 2021
View reviewed changes
Copy link
Member

@jrbourbeau jrbourbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jsignell!

@jrbourbeau jrbourbeau merged commit 30c9a3a into dask:master Jan 20, 2021
@jsignell jsignell deleted the value_counts branch January 20, 2021 22:36
@jsignell jsignell mentioned this pull request Nov 8, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrbourbeau jrbourbeau jrbourbeau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DataFrameGroupBy.value_counts method raises an error when at least a partition is empty.
2 participants
@jsignell @jrbourbeau