-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Temporarily pin fastparquet
in CI
#7907
Conversation
There are some CI failures which appear to be related to the latest ___________ ERROR collecting dask/dataframe/io/tests/test_parquet.py ___________
dask/dataframe/io/tests/test_parquet.py:25: in <module>
import fastparquet
/usr/share/miniconda3/envs/test-environment/lib/python3.7/site-packages/fastparquet/__init__.py:5: in <module>
from .core import read_thrift
/usr/share/miniconda3/envs/test-environment/lib/python3.7/site-packages/fastparquet/core.py:13: in <module>
from .converted_types import convert, simple, converts_inplace
/usr/share/miniconda3/envs/test-environment/lib/python3.7/site-packages/fastparquet/converted_types.py:69: in <module>
np.dtype('bool'): pd.BooleanDtype()
/usr/share/miniconda3/envs/test-environment/lib/python3.7/site-packages/pandas/__init__.py:214: in __getattr__
raise AttributeError("module 'pandas' has no attribute '{}'".format(name))
E AttributeError: module 'pandas' has no attribute 'BooleanDtype' |
Booleans came in in v1.0.0, the one after the 0.25 line - which is 2 years old (today!). We can either skip this up update our min version, if people want. Yes, I realise that the requirement in fastparquet ought to have been updated :| |
If we are following the loose 18 month policy that was discussed in #7378, then we can update to pandas to |
That won't affect the released version, of course. |
You could do a new build on conda-forge. |
Good idea. |
Can try kicking it again whenever we reckon conda-forge posts the new build |
Thanks for the conda-forge update @martindurant. Bumping CI now... |
I don't know if the new build hasn't appeared yet in the channel metadata, or if the resolver will now insist on build 0, since it allows for the desired pandas version. |
I might have bumped too early. I just did |
The linux Python 3.8 build is picking up build 1 of |
Ww should be able to remove build 0; but it might just get the earlier version. That would be OK too , I suppose. |
Temporarily pinning |
fastparquet
in CIfastparquet
in CI
Planning to merge this after CI finishes. I also opened up a PR in |
No description provided.