Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove inplace argument for dask series renaming #8133

Closed
wants to merge 0 commits into from
Closed

Remove inplace argument for dask series renaming #8133

wants to merge 0 commits into from

Conversation

marcelned
Copy link
Contributor

See issue #8082

@GPUtester
Copy link
Collaborator

Can one of the admins verify this patch?

@marcelned marcelned mentioned this pull request Sep 10, 2021
Closed
@jsignell
Copy link
Member

ok to test

jsignell
jsignell reviewed Sep 13, 2021
View reviewed changes
Copy link
Member

@jsignell jsignell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this PR! Since inplace has been supported in the past we should probably deprecate it a little more slowly. It would probably be enough in this PR to do a FutureWarning if inplace is True and leave the rest of the code as is.

@marcelned marcelned closed this Sep 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsignell jsignell jsignell left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marcelned @GPUtester @jsignell