Add scheduler option to assert_eq utilities
#8610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
Are test failures below infra-related? |
|
Yeah the test failures mostly have to do with dask not being quite caught up with the latest release of pandas: #8580 |
|
ok to test |
|
Thanks @jsignell ! |
jsignell
reviewed
Feb 1, 2022
dask/array/tests/test_array_utils.py
Outdated
Comment on lines
114
to
117
| if isinstance(a, Array) and isinstance(b, Array): | ||
| assert counter == 2 | ||
| else: | ||
| assert counter == 0 |
There was a problem hiding this comment.
I really like this test! But this part took me a minute to understand. I am wondering if something like this is clearer:
Suggested change
| if isinstance(a, Array) and isinstance(b, Array): | |
| assert counter == 2 | |
| else: | |
| assert counter == 0 | |
| n_da_arrays = len([x for x in [a, b] if isinstance(x, Array)]) | |
| assert counter == n_da_arrays |
There was a problem hiding this comment.
That's so smart! Committed, thank you.
Co-authored-by: Julia Signell <jsignell@gmail.com>
jsignell
added
enhancement
|
Thanks @xinrong-databricks! This is in :) |
|
Thank you @jsignell ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
assert_equtilities #8583pre-commit run --all-files