Dask.array tracks dtypes when possible #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Array class now holds a `_dtype` attribute. Various dask.array functions propagate dtype information, repeating a bit of numpy logic where necessary. If this logic fails then we fall back on computation of a small element of the dask array. Fixes dask#64
| @@ -465,6 +469,8 @@ def __len__(self): | |||
|
|
|||
| @property | |||
| def dtype(self): | |||
| if self._dtype is not None: | |||
| return self._dtype | |||
| if self.shape: | |||
| return self[(0,) * self.ndim].compute().dtype | |||
There was a problem hiding this comment.
Can you cache the dtype if you need to calculate it?
There was a problem hiding this comment.
Fixed. Note though that I think we've covered most of the operations. I haven't yet done ones, zeros, and da.random, but I think that this PR covers most things.
mrocklin
added a commit
that referenced
this pull request
Mar 24, 2015
Dask.array tracks dtypes when possible
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Array class now holds a
_dtypeattribute. Various dask.array functionspropagate dtype information, repeating a bit of numpy logic where necessary.
If this logic fails then we fall back on computation of a small element of the
dask array.
Fixes #64
cc @shoyer