More dtype tracking #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if not all(a._dtype is not None for a in arrays): | ||
| if 'dtype' in kwargs: | ||
| dt = kwargs['dtype'] | ||
| elif not all(a._dtype is not None for a in arrays): |
There was a problem hiding this comment.
This is the same as elif any(a._dtype is None for a in arrays), I think?
That would avoid the double-negative
Fixes dask#90
| isinf = wrap_elemwise(np.isinf) | ||
| isnan = wrap_elemwise(np.isnan) | ||
| isinf = wrap_elemwise(np.isinf, dtype='bool') | ||
| isnan = wrap_elemwise(np.isnan, dtype='bool') |
There was a problem hiding this comment.
isnull and notnull are also always dtype=bool
This gives significantly more coverage to dtype tracking. Added more logic in a few missing places
|
OK, tests now cover all elementwise operations (I think) and dtype checking is tied into all tests. |
|
Merging this soon if no comment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #89
As @shoyer brings up, #87 is incomplete and contains wrong results. We'll fix some here. Presumably we'll fail to find a few. Is the current approach best or should we always rely on some small amount of computation?