Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pyarrow-legacy engine from parquet API #8835

Merged
merged 4 commits into from
Apr 4, 2022

Conversation

rjzamora
Copy link
Member

Removes parquet "pyarrow-legacy" engine. This is a follow-up to #8758 and the final step in #8243

I'm not sure how long we want to wait from the date #8758 to release this, but doing so will certainly help with maintenance a bit :)

@rjzamora rjzamora changed the title remove pyarrow-legacy Remove pyarrow-legacy engine from parquet API Mar 23, 2022
@rjzamora rjzamora added parquet deprecation Something is being removed labels Mar 23, 2022
@jcrist
Copy link
Member

jcrist commented Mar 24, 2022

Why don't we merge this after our next release? Gives a little over a month of deprecation warning in effect, and it hasn't been the default engine for a while.

@jcrist jcrist marked this pull request as ready for review April 1, 2022 19:59
@jcrist
Copy link
Member

jcrist commented Apr 1, 2022

I've merged this with main and pushed a small fixup - I believe this should be good to merge once tests pass. Thanks @rjzamora!

edit: looks like there are some test failures, will fix

@jcrist
Copy link
Member

jcrist commented Apr 4, 2022

Errors are unrelated, merging. Thanks @rjzamora!

@jcrist jcrist merged commit 0b36d7f into dask:main Apr 4, 2022
@rjzamora
Copy link
Member Author

rjzamora commented Apr 4, 2022

Thanks for taking care of this @jcrist !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate "pyarrow-legacy" engine in dask.dataframe.read_parquet
3 participants