advised not to use map_block()'s drop_axis on chunked axes of an array
#8921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ParticularMiner
force-pushed
the
drop_axis
branch
from
8ef04d3
to
9da0327
Compare
|
@ParticularMiner Thanks for opening this PR! Noting that it's related to #8870. The failing ubuntu-py3.10 is a known flaky test (#8062). @jsignell Do you have thoughts on this? |
|
Looks good to me! Thanks @ParticularMiner |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pre-commit run --all-filescc: @jsignell
I forgot to add one important detail when describing
map_blocks()'sdrop_axisoption in the docs.