Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a CLI command to list and get a value from dask config #9936

Merged

Conversation

j-bennet
Copy link
Contributor

@j-bennet j-bennet commented Feb 10, 2023

Adds two cli commands, git config get to get a value from dask config:

> dask config get distributed.scheduler.dashboard
bokeh-application:
  allow_websocket_origin:
  - '*'
  check_unused_sessions_milliseconds: 500
  keep_alive_milliseconds: 500
status:
  task-stream-length: 1000
tasks:
  task-stream-length: 100000
tls:
  ca-file: null
  cert: null
  key: null

or git config list to print the whole config:

> dask config list
array:
  backend: numpy
  slicing:
    split-large-chunks: null
  svg:
    size: 120
coiled:
...

Partially implements #9746.

  • Tests added / passed
  • Passes pre-commit run --all-files

@j-bennet j-bennet marked this pull request as draft February 10, 2023 01:49
@j-bennet j-bennet marked this pull request as ready for review February 10, 2023 17:14
@j-bennet
Copy link
Contributor Author

cc @ntabris

Copy link
Contributor

@milesgranger milesgranger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one nit/question, but I don't think my approval truly means anything yet without more permissions. :)

dask/cli.py Outdated Show resolved Hide resolved
Copy link
Member

@hendrikmakait hendrikmakait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @j-bennet. I have one minor nit; feel free to ignore it.

dask/cli.py Outdated Show resolved Hide resolved
dask/cli.py Show resolved Hide resolved
@j-bennet j-bennet force-pushed the j-bennet/9746-get-dask-config-values branch from af6cd6e to b61df0d Compare April 5, 2023 22:39
@j-bennet j-bennet changed the title Add a CLI command to get a value from dask config. Add a CLI command to list and get a value from dask config Apr 5, 2023
@hendrikmakait hendrikmakait merged commit b86786e into dask:main Apr 6, 2023
@j-bennet j-bennet deleted the j-bennet/9746-get-dask-config-values branch April 6, 2023 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants