-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run GPU tests on python 3.8 & 3.10 #9940
Conversation
This makes sense to me, best to test with the oldest support. Thanks @charlesbluca and @jakirkham ! |
Thanks Charles! 🙏 Is there anything else needed before marking this ready for review? |
Chatted with @ajschmidt8 and seems like it's pretty trivial to run testing for both python 3.8 and 3.10 on each PR (a run for example): https://gpuci.gpuopenanalytics.com/job/dask/job/dask/job/prb/job/dask-prb/3428/ Given this, how do we feel about running the GPU tests on both 3.8 and 3.10? Don't think should have much of an impact on the overall runtime of CI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @charlesbluca!
both python 3.8 and 3.10 on each PR
I'm curious why Python 3.10 instead of Python 3.11?
RAPIDS deprecated python 3.9 support in 22.12, and moving forward plans to maintain support for 3.8 and 3.10. |
Ah, I see. I hadn't realized that, thanks for clarifying. I'll defer to folks like yourself, John, and Peter about what's best here. It looks like testing on 3.8 and 3.10 doesn't have a big impact on overall CI runtime, so I think we're good on that front 👍 |
Just to add to Charles' response, RAPIDS only recently added Python 3.10 support and has not yet added Python 3.11 support. |
+1 As long as we include Python 3.8, happy with any other CI jobs. |
expect = pdf.groupby(pd_grouper).sum() | ||
# cuDF's numeric behavior aligns with numeric_only=True | ||
expect = pdf.groupby(pd_grouper).sum(numeric_only=True) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @rjzamora (for awareness)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @charlesbluca
In rapidsai/dask-build-environment#58, @jakirkham suggested that it might be worth running GPU testing against python 3.8 (currently the lowest Python version supported by RAPIDS):
Interested in if any failures will crop up here, and also to solicit opinions from other RAPIDS maintainers (cc @pentschev @quasiben)
pre-commit run --all-files