Use client connection and serialization arguments in progress #2035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The TLS stuff is not well tested here yet. |
mrocklin
force-pushed
the
diagnostics-client-kwargs
branch
from
8259598
to
b17f002
Compare
|
TLS is now wel tested |
Previously the progress bars failed to use client options like connection_args, serializers, and deserializers when connecting and communicating with the scheduler. This resulted in a lack of support for TLS, and the possibility of dangerous communication if the scheduler was compromised. We now capture the client from the passed-in futures and then use these settings appropriately. Fixes dask#2032
mrocklin
force-pushed
the
diagnostics-client-kwargs
branch
from
b17f002
to
0f5dc1f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the progress bars failed to use client options like
connection_args, serializers, and deserializers when connecting and
communicating with the scheduler. This resulted in a lack of support
for TLS, and the possibility of dangerous communication if the scheduler
was compromised.
We now capture the client from the passed-in futures and then use these
settings appropriately.
Fixes #2032