Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround for hanging test now calls ucp.fin() #2967

Merged
merged 1 commit into from Aug 20, 2019

Conversation

@madsbk
Copy link
Contributor

@madsbk madsbk commented Aug 20, 2019

The workaround in test_ucx.py to fix hanging is now calling ucp._libs.ucp_py.fin().
Calling ucp._libs.ucp_py.reader_added = 0 didn't work since it would only partial reset the system.
Hopefully, when UCX-Py is more mature this won't be necessary.

(cc @mrocklin)

@jakirkham jakirkham requested a review from quasiben Aug 20, 2019
@mrocklin
Copy link
Member

@mrocklin mrocklin commented Aug 20, 2019

Forwarding the cc to @quasiben

Loading

Copy link
Member

@quasiben quasiben left a comment

Thanks @madsbk !

Loading

@quasiben quasiben merged commit b083b10 into dask:master Aug 20, 2019
2 checks passed
Loading
@quasiben
Copy link
Member

@quasiben quasiben commented Aug 20, 2019

Tested on a DGX and everything passed

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants