Workaround for hanging test now calls ucp.fin()
#2967
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The workaround in
test_ucx.py
to fix hanging is now callingucp._libs.ucp_py.fin()
.Calling
ucp._libs.ucp_py.reader_added = 0
didn't work since it would only partial reset the system.Hopefully, when UCX-Py is more mature this won't be necessary.
(cc @mrocklin)