Clear task stream based on recent behavior #3200
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #3190 cc @dickreuter
I tried to breifly implement my proposed solution to clearing the task stream based on recent behavior. It only runs the check if we haven't seen an update in a suitable amount of time (which is nice for performance) and then bases the decision on the current timespan of the rectangles in the plot. In principle this works fairly nicely.
However, it does have a fail case when building up a larger and larger task stream plot over time. If you start having these large gaps in the stream then things can get harder and harder to clear out. Probably we should have some other check as well that attempts to understand the amount of whitespace in the plot currently. Perhaps some measure of the sum of the durations / workers over the total timespan.
@dickreuter I mostly wanted to share this to communicate what I was trying to say in the issue earlier. Maybe it helps make my original intent more clear.