-
-
Notifications
You must be signed in to change notification settings - Fork 717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support different remote_python paths on cluster nodes #4085
Conversation
@jacobtomlinson I would appreciate your feedback on this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this @abduhbm.
My main comment here is other options take either a single option or a list of options. So for connect_options
it can either be a dictionary of settings which are applied to all connections, or a list of dictionaries.
The list length must match the order and length of the addresses list.
I would suggest this should follow the same pattern.
@jacobtomlinson thanks for the feedback. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great thanks
My apologies for the delay. @jacobtomlinson thank you for the review. I'm merging this in. Thanks @abduhbm ! |
Trying to resolve #4063
@jacobtomlinson please let me know if more work is needed here. Thanks,