Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Place an upper limit on the click version #6014

Closed
wants to merge 2 commits into from

Conversation

ChiliJohnson
Copy link

This places an upper limit on the required click version, the latest version does not include the required _unicodefun module.

@GPUtester
Copy link
Collaborator

Can one of the admins verify this patch?

@github-actions
Copy link
Contributor

Unit Test Results

       12 files  ±0         12 suites  ±0   6h 7m 53s ⏱️ - 4m 5s
  2 674 tests ±0    2 592 ✔️ +1    82 💤 ±0  0  - 1 
15 948 runs  ±0  15 089 ✔️ ±0  859 💤 +1  0  - 1 

Results for commit 967434c. ± Comparison against base commit e8c0669.

@graingert
Copy link
Member

I think it's better to just drop the unicode check now that distributed only supports 3.8+ #6018

@graingert graingert requested a review from fjetter March 29, 2022 13:43
@graingert
Copy link
Member

@ChiliJohnson thank you for the PR, however distributed now supports click >= 8.1.0 on main so I'm closing this now

@graingert graingert closed this Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ImportError: cannot import name '_unicodefun' from 'click'
3 participants